Fix for texture animation#35
Open
davidlyons wants to merge 1 commit intostemkoski:masterfrom
davidlyons:patch-1
Open
Fix for texture animation#35davidlyons wants to merge 1 commit intostemkoski:masterfrom davidlyons:patch-1
davidlyons wants to merge 1 commit intostemkoski:masterfrom
davidlyons:patch-1
Conversation
When a texture animation has multiple rows, like the explosion boomer, it was cycling through the frames in the wrong order. This fix starts with the top row and moves down, instead of starting with the bottom row and moving up. Tile 0 is now the top left, rather than the bottom left.
|
I think it should be optionalized since it makes sense in the GL World to go y up rather then down. Although i totally agree that most sprite generators do not work that way, which also makes sense in their own context. But thank you for putting it out there. I actually had the same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a texture animation has multiple rows, like the explosion boomer, it was cycling through the frames in the wrong order. This fix starts with the top row and moves down, instead of starting with the bottom row and moving up. Tile 0 is now the top left, rather than the bottom left.